Skip to content

Commit

Permalink
Remove default plugins (#70)
Browse files Browse the repository at this point in the history
Default plugins should be installed only using
the blueprint mechanism from the ecosystem. With
the old list of default plugins, this was not
really usable, because the old list of default
plugins always installed nearly all plugins
available, so that the user had no way to create
a smaller default set.

So with this, we completely remove the default
plugin list. All necessary plugins like the
legacy plugins for CAS will still be installed by
the dependency checks.
  • Loading branch information
pfeuffer committed Jun 28, 2023
1 parent b25835c commit beb0407
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- [#72] Configuration options for resource requirements
- [#72] Defaults for CPU and memory requests
### Removed
- Default Plugins ([#70](https://github.com/cloudogu/scm/pull/70/files))


## [2.44.2-1]
### Changed
Expand Down
33 changes: 0 additions & 33 deletions resources/var/tmp/scm/init.script.d/040-install-plugins.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -4,33 +4,6 @@ import sonia.scm.plugin.PluginManager;
import groovy.json.JsonSlurper;

// configuration
def defaultPlugins = [
"scm-mail-plugin",
"scm-review-plugin",
"scm-tagprotection-plugin",
"scm-jira-plugin",
"scm-activity-plugin",
"scm-statistic-plugin",
"scm-pathwp-plugin",
"scm-branchwp-plugin",
"scm-notify-plugin",
"scm-authormapping-plugin",
"scm-groupmanager-plugin",
"scm-pushlog-plugin",
"scm-support-plugin",
"scm-directfilelink-plugin",
"scm-readme-plugin",
"scm-editor-plugin",
"scm-landingpage-plugin",
"scm-repository-template-plugin",
"scm-commit-message-checker-plugin",
"scm-trace-monitor-plugin",
"scm-markdown-plantuml-plugin",
"scm-repository-avatar-plugin",
"scm-ssl-context-plugin",
"scm-repository-mirror-plugin"
];

def plugins = []
def pluginsFromOldInstallation = []

Expand Down Expand Up @@ -137,12 +110,6 @@ if (isDoguInstalled("gotenberg")) {
plugins.add("scm-gotenberg-plugin")
}

// install default plugins
if (isFirstStart()) {
System.out.println("First start detected; installing default plugins.");
plugins.addAll(defaultPlugins)
}

addMissingDefaultPluginsFromEtcd(plugins)

File pluginListFile = new File(sonia.scm.SCMContext.getContext().getBaseDirectory(), "installed_plugins_before_update.lst")
Expand Down

0 comments on commit beb0407

Please sign in to comment.