New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the correct type of redmine config #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. If no etcd value is provided, then easyredmine gets prefered
eheimbuch
reviewed
Oct 11, 2023
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
pfeuffer
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, only one irritation, a typo and one suggestion 👍🏽
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
resources/var/tmp/scm/init.script.d/080-redmine-configuration.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both types of redmine dogus are installed Easy Redmine gets prefered, unless the user configured the scm dogu property redmine_type with the value "REDMINE".
If only one type of redmine dogu is installed, then the script uses that one.
To test the script use vagrant and this repo: https://github.com/cloudogu/ecosystem
If you have trouble connecting to the ecosystem then uncomment the line
config.vm.network "public_network"
To install easyredmine dogu, I used this repo: https://github.com/cloudogu/easyredmine