Enhance accessibility for keyboard #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change css to target changed html correctly, #18
The warp menu is opened by a button on the right-hand side of the screen. This button was implemented as an empty link-element. To make it more accessible I changed this element to a button. This button can be triggered by the keyboard (space and enter). To further enhance accessibility for visually challenged persons I added aria-labels. I simplified the styling to work with chrome and ie browsers. resolves #22
jsprey
approved these changes
Apr 7, 2021
…to feature/accessible_warp_menu
jsprey
approved these changes
Apr 7, 2021
sklein94
added a commit
that referenced
this pull request
Apr 20, 2021
Fixed - Reapplied lost changes in PR #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Make warp menu accessible by keyboard #22