Make it explicit that cloudpickle cannot be used across different Python versions #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon versions As suggested in #293 (comment) And also add a security notice. This is not specific to cloudpickle as `load` / `loads` come from the Python standard library but it's better to be explicit that loading pickle payloads from untrusted sources is a security vulnerability.
pierreglaser
approved these changes
Jun 14, 2019
|
Merged. The cython failure in the python / numpy nightly build is annoying but unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #293 (comment).
And also add a security notice. This is not specific to cloudpickle as
load/loadscome from the Python standard library but it's better to be explicit that loading pickle payloads from untrusted sources is a security vulnerability.