Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reduce for objects derived from abstract decorators #369

Closed

Conversation

KristianHolsheimer
Copy link

This PR fixes #367

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #369 into master will decrease coverage by 32.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #369       +/-   ##
===========================================
- Coverage   92.95%   60.88%   -32.07%     
===========================================
  Files           2        2               
  Lines         809      813        +4     
  Branches      164      164               
===========================================
- Hits          752      495      -257     
- Misses         29      305      +276     
+ Partials       28       13       -15     
Impacted Files Coverage Δ
cloudpickle/cloudpickle_fast.py 95.79% <100.00%> (+0.07%) ⬆️
cloudpickle/cloudpickle.py 46.43% <0.00%> (-45.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70dc1df...b199215. Read the comment docs.

@KristianHolsheimer
Copy link
Author

I don't have time to work on this to figure out what goes wrong with python versions < 3.8.

I'll abandon this PR, but I'll leave the issue #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pickle classes derived from ABC with abc.abstract* decorators
1 participant