Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive testing for ABC #371

Merged
merged 1 commit into from May 20, 2020

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented May 20, 2020

This improves the test that check the support for ABC by:

  • using a natural Python 3 syntax to define the ABC class now that Python 2 support has been dropped;
  • checks interactions between @abstractmethod and @staticmethod and @classmethod.

Related to the discussion in #367.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files           2        2           
  Lines         809      809           
  Branches      164      164           
=======================================
  Hits          752      752           
  Misses         29       29           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70dc1df...27757e2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant