Fix #94: allow pickling Logger objects #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
+ Coverage 79.88% 80.18% +0.3%
=========================================
Files 2 2
Lines 522 530 +8
Branches 109 110 +1
=========================================
+ Hits 417 425 +8
Misses 75 75
Partials 30 30
Continue to review full report at Codecov.
|
tests/cloudpickle_test.py
Outdated
|
|
||
| dumped = cloudpickle.dumps(logger) | ||
|
|
||
| code = """if 1: |
There was a problem hiding this comment.
You could use textwrap.dedent here to fix the indentation instead of the if.
There was a problem hiding this comment.
textwrap.dedent is a bit more annoying to use (you have to make sure the first line has the same indent as the other ones, which this idiom doesn't require).
|
Interesting: the |
|
So, my experience when I run into the issue of cloudpickle not being able to serialize a logger is that cloudpickle is actually trying to serialize everything. The solution in these cases is almost always to find out why. It's probably still correct for cloudpickle to learn how to serialize logger objects, but we may want to ask ourselves why this is occurring. |
It's occurring simply because Logger objects don't have a custom |
|
Note reconstructing by calling |
|
Are there any other comments before this get merged? |
## What changes were proposed in this pull request? Based on apache#18282 by rgbkrk this PR attempts to update to the current released cloudpickle and minimize the difference between Spark cloudpickle and "stock" cloud pickle with the goal of eventually using the stock cloud pickle. Some notable changes: * Import submodules accessed by pickled functions (cloudpipe/cloudpickle#80) * Support recursive functions inside closures (cloudpipe/cloudpickle#89, cloudpipe/cloudpickle#90) * Fix ResourceWarnings and DeprecationWarnings (cloudpipe/cloudpickle#88) * Assume modules with __file__ attribute are not dynamic (cloudpipe/cloudpickle#85) * Make cloudpickle Python 3.6 compatible (cloudpipe/cloudpickle#72) * Allow pickling of builtin methods (cloudpipe/cloudpickle#57) * Add ability to pickle dynamically created modules (cloudpipe/cloudpickle#52) * Support method descriptor (cloudpipe/cloudpickle#46) * No more pickling of closed files, was broken on Python 3 (cloudpipe/cloudpickle#32) * ** Remove non-standard __transient__check (cloudpipe/cloudpickle#110)** -- while we don't use this internally, and have no tests or documentation for its use, downstream code may use __transient__, although it has never been part of the API, if we merge this we should include a note about this in the release notes. * Support for pickling loggers (yay!) (cloudpipe/cloudpickle#96) * BUG: Fix crash when pickling dynamic class cycles. (cloudpipe/cloudpickle#102) ## How was this patch tested? Existing PySpark unit tests + the unit tests from the cloudpickle project on their own. Author: Holden Karau <holden@us.ibm.com> Author: Kyle Kelley <rgbkrk@gmail.com> Closes apache#18734 from holdenk/holden-rgbkrk-cloudpickle-upgrades.
No description provided.