Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable component inheritance chain #85

Merged
merged 1 commit into from Dec 9, 2021
Merged

Disable component inheritance chain #85

merged 1 commit into from Dec 9, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Dec 9, 2021 •
edited

what

  • Disable component inheritance chain for now to make all stacks work

why

  • While it's working in all the tests, and in 99% of the real infra stacks, some edge cases of stack config are not handled correctly and cause gorotine panic
  • All edge cases will be tested and fixed in the consecutive PR

@aknysh aknysh self-assigned this Dec 9, 2021
@aknysh aknysh requested review from a team as code owners December 9, 2021 14:48
@aknysh aknysh added the patch A minor, backward compatible change label Dec 9, 2021
@aknysh aknysh merged commit c9ba708 into master Dec 9, 2021
@aknysh aknysh deleted the fix-inheritance-chain branch December 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@osterman osterman Awaiting requested review from osterman

@Nuru Nuru Awaiting requested review from Nuru

@korenyoni korenyoni Awaiting requested review from korenyoni

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aknysh @nitrocode