Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator/monochart] allow monochart to be optional #162

Closed
osterman opened this issue Sep 3, 2018 · 1 comment
Closed

[incubator/monochart] allow monochart to be optional #162

osterman opened this issue Sep 3, 2018 · 1 comment
Assignees
@alebabai
Labels
enhancement
Projects
Open Source Community Support

Comments

@osterman
Copy link
Member

osterman commented Sep 3, 2018

what

  • Allow caller to disable monochart from appearing in release name
  • Allow caller to override monochart release name

why

  • monochart in release name does not convey useful information
@osterman osterman added this to Ready to Implement in Open Source Community Support via automation Sep 3, 2018
@alebabai
Copy link
Contributor

alebabai commented Sep 4, 2018

This feature is already implemented in common chart.
https://github.com/helm/charts/tree/master/incubator/common#commonfullname

helm upgrade --install nginx incubator/monochart/ --set fullnameOverride=nginx -f incubator/monochart/values.example.yaml

@osterman osterman closed this as completed Sep 4, 2018
Open Source Community Support automation moved this from Ready to Implement to Completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alebabai alebabai

Labels
enhancement
Projects
Open Source Community Support
  
Completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osterman @alebabai