Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR & Release management maintenance #940

Merged
merged 3 commits into from
May 11, 2024
Merged

PR & Release management maintenance #940

merged 3 commits into from
May 11, 2024

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented May 10, 2024

what

  • Install font needed by vhs-action in a separate step
  • Label PRs that only affect the Alpine version as alpine-only
  • Exclude Apline-only PRs from release notes
  • Add a standard catchall to every release note

why

  • Work around broken install-fonts in vhs-action
  • Deprecate Alpine, focus release notes on Debian
  • The AWS CLI v1 and boto3 release notes are huge and yet not very informative
  • Packages are updated on every release, without those changes being documented, so let people know that

references

@Nuru Nuru requested a review from a team as a code owner May 10, 2024 22:49
@Nuru Nuru force-pushed the vhs-fonts branch 2 times, most recently from 152ff29 to 10688e8 Compare May 10, 2024 23:11
Comment on lines -40 to -49
Type "# It ships with common commands like `terraform`" Enter
Sleep 500ms

Type "terraform -help" Enter
Sleep 500ms

Type "# ...and the `aws` CLI =)" Enter
Sleep 500ms

Type "aws help" Enter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can we showcase then that make it more than jq. Not that it was awe-inspiring in the previous version, this is definitely less.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we at least bundle atmos

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK. I took out Terraform in favor of having the option to use Tofu, and aws in preparation for the cloud-agnostic version of Geodesic. Really kubectl is the biggest thing left, and after that, it is mostly the scripts, prompt, integration, etc. that make Geodesic wonderful. It is great that we have a robust set of tools, but they mostly follow the Unix preference of doing one thing well and being composable, so not flashy on their own.

I suppose we could ls /usr/local/bin, which is empty on debian-slim.

2to3@		      docs*			    pip3.12*
2to3-3.12*	      eks-update-kubeconfig*	    pydoc@
annotate-namespace*   eks-update-kubeconfig.draft*  pydoc3@
args*		      emailcli@			    pydoc3.12*
awless@		      geodesic-aptindex-md5*	    python@
aws@		      git-credential-github*	    python-config@
aws-config-setup*     goofys@			    python3@
aws-region*	      grafana-db*		    python3-config@
aws2@		      helm3-metadata-fix*	    python3.12*
aws2_completer@       helmctl*			    python3.12-config*
aws_completer@	      idle@			    s3*
boot*		      idle3@			    session-manager-plugin@
build-kops-manifest*  idle3.12*			    short.txt
build-kubecfg*	      init*			    terminal-server
cfssl@		      install-docker-command*	    tfenv@
codefresh-pipeline*   kopsctl*			    tfmask@
codefresh-settings*   kubectl-auto-select*	    tmate-session*
conf-directory*       make*			    to_short.txt
confirm*	      new-project*		    twiddle*
crudini*	      no-arm64-support*		    wheel*
deps*		      pip*			    wrapper*
destroy-namespace*    pip3*			    yaml-diff*

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important thing is that I got vhs working again. You can update the demo whenever you feel inspired.

I do not want to install Atmos, because that triggers the Atmos integrations, which will not work in the demo environment (no stacks, no components).

It is kind of ironic that we install about 60 packages and still do not have an easy way to show the power of Geodesic, but in reality, the advantage is we have done all the work to curate, install, and integrate the packages. Plus, as I said before, all the integrations, particularly with Kubernetes (Helm, Helm plugins, Kubeprompt, etc.) and AWS, like assuming roles and connecting to EKS clusters. All hard to show off on a demo running without any code, configuration, or credentials.

@Nuru Nuru requested a review from osterman May 11, 2024 00:06
@Nuru Nuru merged commit 0d42ba1 into main May 11, 2024
2 checks passed
@Nuru Nuru deleted the vhs-fonts branch May 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants