Fix default target group count #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhkikuchi
requested review from
dotCipher and
dylanbannon
and removed request for
a team
|
see the original issue #94 if we want to change this back then at least lets prevent it from being created when both are set to fixed response |
Or maybe add a variable |
Thank you, have updated |
nitrocode
reviewed
Dec 6, 2021
…kikuchi/terraform-aws-alb into linh-fix-default-target-group-count
nitrocode
approved these changes
Dec 8, 2021
|
/test all |
SatyaVadapalli
pushed a commit
to teamclairvoyant/terraform-aws-alb
that referenced
this pull request
Jun 29, 2022
* Fix default target group count * Add variable default_target_group_enabled * Auto Format * Update variables to enable default target group * Auto Format Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
listener_https_fixed_responsebut still need the default target group created in this module. It used to work before this PR (Addmodule.this.enabledcheck to listener'scount#97). Do not see why it should not get created when we havelistener_https_fixed_response