Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module.this.enabled check to listener's count #97

Merged
merged 5 commits into from Aug 18, 2021
Merged

Add module.this.enabled check to listener's count #97

merged 5 commits into from Aug 18, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Aug 2, 2021 •
edited

what

  • Add module.this.enabled check to listener's count

why

  • To ensure this module can be properly disabled using enabled = false

references

@nitrocode nitrocode requested review from a team as code owners August 2, 2021 21:28
@nitrocode nitrocode requested review from dotCipher and florian0410 and removed request for a team August 2, 2021 21:28
@nitrocode
Copy link
Member Author

/test all

@mergify
Copy link

mergify bot commented Aug 18, 2021

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 7128c61 into master Aug 18, 2021
@nitrocode nitrocode deleted the listener_enabled branch August 18, 2021 01:53
@linhkikuchi linhkikuchi mentioned this pull request Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@florian0410 florian0410 Awaiting requested review from florian0410

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orphaned Target Group "default" Module can't be destroyed with enabled = false
2 participants
@nitrocode @jamengual