Variables in additional_bucket_policy are not substituted anymore

[rafaljanicki]

Describe the Bug

The documentation states that the additional_bucket_policy variable supports variables inside such as ${bucket_name}. However, that doesn't seem to be the case anymore and the variable is passed to Terraform without any replace done. That's probably done because of the lack of template_file

Expected Behavior

${bucket_name} should be replaced to match the bucket's name

Steps to Reproduce

data "aws_iam_policy_document" "document" {
  dynamic "statement" {
    for_each = var.accounts

    content {
      sid = "JustASide${each.key}"

      actions = ["s3:GetObject"]
      resources = [
        "arn:aws:s3:::$${bucket_name}",
        "arn:aws:s3:::$${bucket_name}/*"
      ]

      principals {
        type = "AWS"
        identifiers = ["arn:aws:iam::${statement.value}:root"]
      }
    }
  }
}

module "cloudfront-s3-apigateway-cdn" {
  source = "cloudposse/cloudfront-s3-cdn/aws"
  version = "~> 0.59"

  compress = true
  dns_alias_enabled = true
  price_class = "PriceClass_All"

  acm_certificate_arn = var.static_acm_certificate_arn
  aliases = ["static.${var.static_domain_name}"]
  block_origin_public_access_enabled = true
  environment = var.environment
  name = "static"
  origin_force_destroy = true
  origin_ssl_protocols = ["TLSv1.2"]
  parent_zone_id = var.static_domain_name_zone_id
  website_enabled = true

  additional_bucket_policy = data.aws_iam_policy_document.document.json

  tags = local.common_tags
}

Environment:

Anything that will help us triage the bug will help. Here are some ideas:

• OS: OSX
• Module version: 0.59

Additional context

The behaviour was removed with this commit: c7e6f3e