Allow creating a policy for an existing S3 bucket

[emyller]

what

• Fix creating a S3 bucket policy when using an existing S3 bucket.

why

• The code was only considering the bucket object managed by this module.

references

• Closes Unable to override policy of existing S3 bucket #152.

[nitrocode]

/test all

[emyller]

@nitrocode I can't make complete sense out of the errors pointed by CI. Would you give me a hint at how to fix these?

[nitrocode]

Try the following to kick off the build

git commit --allow-empty
git push -f

[emyller]

@nitrocode No luck. The log complains it can't push to my repo, or so it looks like:

+ git push
remote: Permission to continuumvip/terraform-aws-cloudfront-s3-cdn.git denied to cloudpossebot.
fatal: unable to access 'https://github.com/continuumvip/terraform-aws-cloudfront-s3-cdn/': The requested URL returned error: 403

Should the bot really be trying to do that?

[nitrocode]

Yes it should as that's how the Auto Format works. It clones your repo, checks if formatting is necessary, and then pushes up any changes.

You can format the code yourself and it will bypass that bot if you like or you can give your fork permission to the cloudposse bot.

[emyller]

(...) or you can give your fork permission to the cloudposse bot.

Cool, that makes sense. I have invited the bot to the repository as a contributor, it's pending the invite. Can you please accept it and let me know so we can try triggering CI again? Thanks!

[pearsonhenri]

Anything I can do to help on this PR? Would looove to pull these changes in :)

[emyller]

@pearsonhenri I think we need Cloudposse to accept the invite to their bot account so it can push to the fork, or a volunteer to set up their linting environment locally and contribute with the necessary changes -- sorry I don't have time to do the latter. Right now this is basically how I'm using this module and it's fine:

module "my_cdn" {
  # source = "cloudposse/cloudfront-s3-cdn/aws"
  # version = "0.59.0"
  source = "github.com/continuumvip/terraform-aws-cloudfront-s3-cdn?ref=2f24a73"
  ...
}

[Gowiem]

/test all

[Gowiem]

@emyller you can run the formatting code yourself by doing the following:

make init 
make pr/auto-format

Then commit your changes and push the result and that should get this passed that annoying auto-format bit.

Apologies for the delay, please ping me directly once you've done the above steps or post in #pr-reviews in the SweetOps Slack and somebody else will get to it.

[emyller]

/test all

[emyller]

Then commit your changes and push the result and that should get this passed that annoying auto-format bit.

Thanks @Gowiem. Can you please re-add your review?

[Gowiem]

/teset all

[Gowiem]

/test all

[Gowiem]

Thanks for the contribution @emyller! Released as 0.62.0.

[pearsonhenri]

Yay thanks y'all!