Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-service: circuit breaker params are ignored #931

Open
johncblandii opened this issue Dec 12, 2023 · 0 comments
Open

ecs-service: circuit breaker params are ignored #931

johncblandii opened this issue Dec 12, 2023 · 0 comments
Labels
bug 🐛 An issue with the system

Comments

@johncblandii
Copy link
Contributor

Describe the Bug

https://github.com/cloudposse/terraform-aws-components/blob/main/modules/ecs-service/main.tf#L259

deployment_controller_type = lookup(local.task, "deployment_controller_type", null) ends up passing in null which does not default to ECS for this conditional https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/blob/main/main.tf#L642 so circuit_breaker_deployment_enabled and circuit_breaker_rollback_enabled never get enabled.

Expected Behavior

...
        task:
          circuit_breaker_deployment_enabled: true
          circuit_breaker_rollback_enabled: true

...should trigger...

      ~ deployment_circuit_breaker {
          ~ enable   = false -> true
          ~ rollback = false -> true
        }

Changing the values should trigger an update, but it requires manually setting deployment_controller_type: ECS.

Steps to Reproduce

Enable the circuit breaker for a task without explicitly setting the deployment controller.

Screenshots

No response

Environment

No response

Additional Context

No response

@johncblandii johncblandii added the bug 🐛 An issue with the system label Dec 12, 2023
@johncblandii johncblandii changed the title ecs-service: ecs-service: circuit breaker params are ignored Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant