-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Implementation #1
Comments
Resources sound good, except for not sure how we can leverage the DNS record with an ASG? We should also define the outputs. I think they would be... outputs
variables
Note, the labels module will output referencesRefer to these modules/variables for inspiration:
Note, @Jamie-BitFlight has offered to donate any/all of his code under the |
That sounds good. I like that. I was thinking the DNS record would be used only if enabled and an ELB and EIP was requested. Thoughts? |
I think the ALB belongs outside of this module for greatest flexibility and re-use. For example, we're using these ALB modules for ECS, but they will work for many other use-cases. Check these out:
Perhaps the module can take as an input the target groups ARNs and use the https://www.terraform.io/docs/providers/aws/r/autoscaling_attachment.html |
I like that, sounds good! |
My general thoughts are that it should include the following resources:
Variables:
The text was updated successfully, but these errors were encountered: