Bump AWS provider and update examples to include ECS Service Connect config #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump AWS provider version to support latest ECS Service Connect config
|
/terratest |
- to use portMappings[].name
joe-niland
changed the title
|
/terratest |
- currently not compatible with tcp ports
|
/terratest |
joe-niland
commented
May 17, 2024
examples/complete/main.tf
Outdated
| @@ -117,10 +117,6 @@ module "ecs_alb_service_task" { | |||
| port = 80 | |||
| } | |||
| ] | |||
| timeout = [{ | |||
There was a problem hiding this comment.
@awkaplan FYI, I couldn't get this working with a TCP port.
When Timeout is supplied, even if per_request_timeout_seconds is not supplied, I think the provider is setting the value to 0 which is invalid for a TCP port.
I haven't looked into it in detail, but it would be good if we could fix this as it will come up again.
jamengual
approved these changes
May 17, 2024
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references