Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated overwrite_ssm_parameter #71

Merged
merged 3 commits into from Mar 4, 2024
Merged

Conversation

andruccho
Copy link
Contributor

Removed deprecated overwrite_ssm_parameter.

@hans-d
Copy link
Contributor

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link
Contributor

hans-d commented Mar 3, 2024

@andruccho Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@andruccho
Copy link
Contributor Author

@hans-d Fixed readme which broke the test
This workflow is awaiting approval from a maintainer

@hans-d
Copy link
Contributor

hans-d commented Mar 3, 2024

/terratest

@hans-d
Copy link
Contributor

hans-d commented Mar 3, 2024

I need to look into the terratest check failures, as the failures of those are unrelated to your change.

@hans-d hans-d self-assigned this Mar 3, 2024
@hans-d hans-d removed the stale This PR has gone stale label Mar 3, 2024
@hans-d
Copy link
Contributor

hans-d commented Mar 3, 2024

awaiting #73

@hans-d
Copy link
Contributor

hans-d commented Mar 4, 2024

/terratest

@hans-d hans-d merged commit fcc7ec0 into cloudposse:main Mar 4, 2024
10 checks passed
@hans-d
Copy link
Contributor

hans-d commented Mar 4, 2024

@andruccho merged, and thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants