Version 2.4.0 tries to downscale storage back to original value

[adillonjc]

Describe the Bug

We have a cluster created with

  broker_volume_size            = 1000
...
  storage_autoscaling_max_capacity = 4000

and storage has autoscaled to 2662.

When upgrading to module version 2.4.0, the Terraform plan includes the following:

broker_node_group_info {
  storage_info {
    ebs_storage_info {
      volume_size : 2662 -> 1000
    }
}

This looks like it will downscale the storage back to the original size. When upgrading to version 2.3.1 we don't see this behavior.

Expected Behavior

TF plan should not include a change to volume_size just by upgrading module version.

Steps to Reproduce

I haven't attempted to reproduce it outside of our existing cluster, but I think this would work: Using a module version 2.3.1 or less, use storage_autoscaling_max_capacity greater than the broker_volume_size, create the cluster, then get storage to autoscale. Then upgrade the module to 2.4.0.

Screenshots

No response

Environment

• Terraform v1.3.2 (Terraform Cloud)
• upgrading module version from 0.8.4 to 2.4.0 causes the issue, but upgrading from 0.8.4 to 2.3.1 doesn't

Additional Context

No response