accepter_subnet_tags doesn't have any effect

[maxvasylets]

Describe the Bug

accepter_subnet_tags doesn't have any effect, data.aws_route_tables.accepter always contains the all route tables in accepter VPS (link to code)

requester_subnet_tags works as expected.

Expected Behavior

Just works as described in the readme.

Steps to Reproduce

Code to reproduce the behavior:

module "prod_to_stage" {
  source = "git::https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account.git?ref=tags/0.11.0"

  namespace = "namespace"
  stage     = "stage"
  name      = "prod-to-stage"

  requester_aws_assume_role_arn             = "arn:aws:iam::${var.account_id}:role/cross-account-vpc-peering-test"
  requester_region                          = var.region
  requester_vpc_id                          = var.prod_vpc_id
  requester_allow_remote_vpc_dns_resolution = true
  requester_subnet_tags                     = {
    Role = "subnet-private"
  }

  accepter_aws_assume_role_arn             = "arn:aws:iam::${var.stage_account_id}:role/cross-account-vpc-peering-test"
  accepter_region                          = var.region
  accepter_vpc_id                          = var.stage_vpc_id
  accepter_allow_remote_vpc_dns_resolution = true
  accepter_subnet_tags                     = {
    "Role" = "subnet-private"
  }
}

Environment

Anything that will help us triage the bug will help. Here are some ideas:

• terraform 0.12.29
• terraform-aws-vpc-peering-multi-account 0.11.0

[Nuru]

Is this still a problem with the current module? Is #31 still needed?

[maxvasylets]

yes it is

[Nuru]

Not actually fixed by #31 or #44, plus those changes introduced a new bug: #45

I propose the easy fix for this which is to remove the option to filter subnets, since it seems to have never worked correctly. If some restrictions are to be made in the VPC Peering, we need a better way to explain and enforce them. See discussion in #45