Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classiclink support #111

Closed
cdobbyn opened this issue Sep 8, 2022 · 1 comment · Fixed by #112
Closed

Remove classiclink support #111

cdobbyn opened this issue Sep 8, 2022 · 1 comment · Fixed by #112
Labels
bug 🐛 An issue with the system

Comments

@cdobbyn
Copy link
Contributor

cdobbyn commented Sep 8, 2022

Describe the Bug

New versions of the AWS provider are now warning about the deprecated setting enable_classiclink as this functionality no longer exists within AWS.

Expected Behavior

No warning appears.

Steps to Reproduce

  1. Update your AWS provider to the latest version
  2. Try to run a terraform plan for a new or existing VPC.

Screenshots

n/a - see additional context

Environment (please complete the following information):

terraform 1.2.x
aws provider 4.29.0

Additional Context

Fixing this issue will reduce backwards compatibility with older aws providers which required this setting.

Example output:

╷
│ Warning: Argument is deprecated
│ 
│   with module.access_vpc_01.module.this_vpc.aws_vpc.default,
│   on .terraform/modules/access_vpc_01.this_vpc/main.tf line 40, in resource "aws_vpc" "default":
│   40:   enable_classiclink               = local.classiclink_enabled
│ 
│ With the retirement of EC2-Classic the enable_classiclink attribute has
│ been deprecated and will be removed in a future version.
│ 
│ (and 7 more similar warnings elsewhere)
╵

@cdobbyn cdobbyn added the bug 🐛 An issue with the system label Sep 8, 2022
@babebort
Copy link

babebort commented Oct 2, 2022

thill the same

Warning: Argument is deprecated │ │ with module.vpc.aws_vpc.default[0], │ on .terraform/modules/vpc/main.tf line 40, in resource "aws_vpc" "default": │ 40: enable_classiclink = local.classiclink_enabled │ │ With the retirement of EC2-Classic the enable_classiclink attribute has been deprecated and will be removed in a future version. │ │ (and one more similar warning elsewhere)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants