add compression when posting metrics to dd #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robpickerill
force-pushed
the
datadog_compress
branch
from
c825c1b
to
ef66d0e
Compare
|
I think adding a configuration option for compression maybe the best way to go here, will rework the PR to support that. |
robpickerill
force-pushed
the
datadog_compress
branch
2 times, most recently
from
232a7cd
to
a43e4d3
Compare
robpickerill
commented
Apr 24, 2023
robpickerill
force-pushed
the
datadog_compress
branch
from
a43e4d3
to
1a88201
Compare
manugarg
reviewed
Apr 27, 2023
|
I was also thinking about adding a minimum size for compression, like 1kb or 2kb, let me know if you think that would be preferable here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gzip compression when posting metrics to Datadog.