Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerting] Add pagerduty notifications #445

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

robpickerill
Copy link
Contributor

This PR adds an initial thin slice of functionality for PagerDuty alert support.

TODO:

  • Add pagerduty client, with event v2 support
  • Add configurations for pagerduty, example
  • Add notify functionality from cloudprober to notify pagerduty

This PR adds:

  • pagerduty integration through the pagerduty routing key configuration in the probe/notifiers config.
  • trigger events (alarms) for probe alarm configs, using the events v2 API.

It also provides the basis for further development on the following functionality, which I will follow up with as feature requests in the issue tracker, for myself or others to pick up:

  • Enrich events with images.
  • Resolve events, once that functionality is included in cloudprober.

Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@manugarg manugarg merged commit 5f14fa6 into cloudprober:master Aug 7, 2023
8 checks passed
@manugarg manugarg added this to the v0.12.9 milestone Aug 7, 2023
@manugarg
Copy link
Contributor

manugarg commented Aug 7, 2023

Thanks so much, @robpickerill!

@robpickerill robpickerill deleted the pagerduty branch August 8, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants