Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrics] Remove (now) unnecessary metric size check. #447

Merged
merged 1 commit into from Aug 8, 2023
Merged

[metrics] Remove (now) unnecessary metric size check. #447

merged 1 commit into from Aug 8, 2023

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Aug 8, 2023 •
edited

  • This check is wasteful. Eventmetrics to String conversion is not cheap.
  • This is the commit that introduced this check: b1147ad
  • Here is more context on this check:

    cloudprober/logger/logger.go

    Line 69 in 33b78ba

    // MaxLogEntrySize Max size of each log entry (100 KB)

    (Note: I think it's okay to continue to check logs for really big lines as there is nothing wasteful there)

@manugarg manugarg merged commit 05f3e97 into master Aug 8, 2023
10 checks passed
@manugarg manugarg deleted the perf_cleanup branch August 8, 2023 06:46
@chenrui333 chenrui333 mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@manugarg