Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics.latency] Add a new value type LatencyValue #448

Merged
merged 3 commits into from Aug 8, 2023
Merged

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Aug 8, 2023

Changes:

  • Remove AddInt64 and AddFloat64 from the Value interface. This lets us clean up all the implementations.
  • Introduce a new interface type LatencyValue that supports the Values interface and AddFloat64(). Only Float and Distribution types need to meet this interface. As the name says, this interface will be used for latency values.
  • Remove Inc and IncBy from the NumValue interface. Only "Int" type needs to support these methods.
  • Add CloneDist method to Distribution type and use that instead of generic Clone() method that returns a Value.

@manugarg manugarg merged commit fe1d880 into master Aug 8, 2023
10 of 11 checks passed
@manugarg manugarg deleted the latency_value branch August 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant