Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changes to override GCP resources api endpoint #525

Merged
merged 5 commits into from Sep 15, 2023

Conversation

shellyvilenko
Copy link
Contributor

@shellyvilenko shellyvilenko commented Sep 13, 2023

Add ability to override gcp resources api endpoint.

Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comment below.

You'll also need to run tools/gen_pb_go.sh for any changes to the protobuf files.

rds/gcp/proto/config.proto Outdated Show resolved Hide resolved
@shellyvilenko shellyvilenko changed the title add changes to override gce instances api endpoint add changes to override GCP resources api endpoint Sep 14, 2023
@manugarg manugarg merged commit a6ded5c into cloudprober:master Sep 15, 2023
5 checks passed
@manugarg
Copy link
Contributor

@shellyvilenko thanks for the PR!

@manugarg manugarg added this to the v0.13.0 milestone Sep 15, 2023
@manugarg manugarg added the enhancement New feature or request label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants