Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Provide a way to hide secret environment variables. #536

Merged
merged 6 commits into from Sep 21, 2023

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Sep 19, 2023

  • Provide an option to specify secret environment variables, using envSecret keyword.
  • When such variables are present, /config-running will be automatically disabled.
  • Add another page /config-parsed that shows the parsed config and makes it clear which variables are secret.

@manugarg manugarg changed the title [config] Add /config-parsed web page and hide secret envs in it. [config] Provide a way to hide secret environment variables. Sep 19, 2023
@manugarg
Copy link
Contributor Author

Screenshots:

image

image

image

@manugarg manugarg added this to the v0.13.0 milestone Sep 21, 2023
@manugarg manugarg merged commit 4266c33 into master Sep 21, 2023
9 of 10 checks passed
@manugarg manugarg deleted the secret_env branch September 21, 2023 16:40
manugarg added a commit that referenced this pull request Oct 5, 2023
…554)

Fix a bug in the recently introduced functionality (in #536). We were using wrong criteria to determine if we should serve /config-running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant