[bugfix] Add IP to endpoint key. (#535) #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP probes use endpoint key as identifier to decide when to recreate probes. During VM recreations, it is possible for VM name to stay the same but VM IP changes. By adding IP to key, we ensure that in such cases, HTTP probes are recreated.
manugarg
reviewed
Sep 20, 2023
|
Thanks manu, i missed copying that line of code from the internal repo. It is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP probes use endpoint key as identifier to decide when to recreate probes. During VM recreations, it is possible for VM name to stay the same but VM IP changes. By adding IP to key, we ensure that in such cases, HTTP probes are recreated.