Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alerting] Fix PagerDuty resolve request creation. #561

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[alerting] Fix PagerDuty resolve request creation. #561

merged 1 commit into from
Oct 9, 2023

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Oct 9, 2023 •
edited

  • Also, instead of aggregating errors from notifiers and then logging,
    log them right away and don't return errors.
  • Include pagerDuty response in the error message in case of an error.

@manugarg manugarg added this to the v0.13.1 milestone Oct 9, 2023
@manugarg
[alerting] Fix PagerDuty resolve request creation.
6f7a373 
- Also, instead of aggregating errors from notifiers and then logging,
  log them right away and don't return errors.
@manugarg manugarg merged commit 0e307d7 into master Oct 9, 2023
9 of 10 checks passed
@manugarg manugarg deleted the pagerduty branch October 9, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Implement alerting in Cloudprober
Status: Done
Milestone
v0.13.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@manugarg