[surfacer.postgres] Postgresql surfacer bulk inserts #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markoposavec
changed the title
manugarg
reviewed
Apr 14, 2024
There was a problem hiding this comment.
Thanks @markoposavec for this PR. Please take a look at the inline comments.
|
For some reason made a rebase and it shows changes from the other commit about tls. |
That's weird. Can you try the following: I am not sure if above will work, might need to check internet :) |
Co-authored-by: Manu Garg <manugarg@gmail.com>
Co-authored-by: Manu Garg <manugarg@gmail.com>
Co-authored-by: Manu Garg <manugarg@gmail.com>
…loudprober#716) - This is important for Windows tests where deleting the test binary fails if it's still executing (for testing external probe process). - We use a temp pids file to collect the pids of the started processes and kill those pids before exiting the test.
markoposavec
force-pushed
the
postgresql-surfacer-bulk-inserts
branch
from
423d808
to
66fdd7c
Compare
|
that fixed the issue, thanks 😄 |
manugarg
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've added option to add bulk writing into postgres database. Currently all metrics from one metrics event object are written in one transaction which was very slow in my use case because of slow connections towards database. I've added batching of metrics events into one transaction. This change improved the speed in my use case by ~10x.
With default values system is working as it was before, event metrics are sent one by one to database.
Let me know if I should change anything,
Thanks!