Skip to content

Commit

Permalink
feat(facebookmarketing)!: Migrate to Arrow native SDK (#11025)
Browse files Browse the repository at this point in the history
Closes #10740

BEGIN_COMMIT_OVERRIDE
feat: Update to use [Apache Arrow](https://arrow.apache.org/) type system (#11025)

BREAKING-CHANGE: This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). You will also need to update destinations depending on which one you use:
- Azure Blob Storage >= v3.2.0
- BigQuery >= v3.0.0
- ClickHouse >= v3.1.1
- DuckDB >= v1.1.6
- Elasticsearch >= v2.0.0
- File >= v3.2.0
- Firehose >= v2.0.2
- GCS >= v3.2.0
- Gremlin >= v2.1.10
- Kafka >= v3.0.1
- Meilisearch >= v2.0.1
- Microsoft SQL Server >= v4.2.0
- MongoDB >= v2.0.1
- MySQL >= v2.0.2
- Neo4j >= v3.0.0
- PostgreSQL >= v4.2.0
- S3 >= v4.4.0
- Snowflake >= v2.1.1
- SQLite >= v2.2.0

END_COMMIT_OVERRIDE
  • Loading branch information
hermanschaaf committed May 26, 2023
1 parent d321395 commit 10954ce
Show file tree
Hide file tree
Showing 88 changed files with 1,143 additions and 1,148 deletions.
4 changes: 2 additions & 2 deletions plugins/source/facebookmarketing/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-pb-go/specs"
"github.com/cloudquery/plugin-sdk/v2/plugins/source"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/plugins/source"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/rs/zerolog"
)

Expand Down
2 changes: 1 addition & 1 deletion plugins/source/facebookmarketing/client/resolvers.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"time"

"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/thoas/go-funk"
)

Expand Down
10 changes: 6 additions & 4 deletions plugins/source/facebookmarketing/client/transformers.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,19 @@ package client
import (
"reflect"

"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/apache/arrow/go/v13/arrow"

"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

// We can't use the *time.Time type because facebook's time format is not RFC3339.
// '2023-03-05T16:46:23+0200' instead of RFC3339 '2023-03-05T16:46:23+02:00'.
// We use the 'string' golang type, and lated convert to *time.Time in the cq resolver.
// We use the 'datetime' tag to recognize thiese datetime fields
func TypeTransformer(field reflect.StructField) (schema.ValueType, error) {
func TypeTransformer(field reflect.StructField) (arrow.DataType, error) {
if field.Tag.Get("datetime") != "" {
return schema.TypeTimestamp, nil
return arrow.FixedWidthTypes.Timestamp_us, nil
}

return transformers.DefaultTypeTransformer(field)
Expand Down
8 changes: 5 additions & 3 deletions plugins/source/facebookmarketing/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,20 @@ module github.com/cloudquery/cloudquery/plugins/source/facebookmarketing
go 1.19

require (
github.com/apache/arrow/go/v13 v13.0.0-20230526080908-77a71305090f
github.com/cloudquery/plugin-pb-go v1.0.8
github.com/cloudquery/plugin-sdk/v2 v2.7.0
github.com/cloudquery/plugin-sdk/v3 v3.6.6
github.com/rs/zerolog v1.29.0
github.com/thoas/go-funk v0.9.3
)

// TODO: remove once all updates are merged
replace github.com/apache/arrow/go/v13 => github.com/cloudquery/arrow/go/v13 v13.0.0-20230509053643-898a79b1d3c8
replace github.com/apache/arrow/go/v13 => github.com/cloudquery/arrow/go/v13 v13.0.0-20230525142029-2d32efeedad8

require (
github.com/andybalholm/brotli v1.0.5 // indirect
github.com/apache/arrow/go/v13 v13.0.0-20230509040948-de6c3cd2b604 // indirect
github.com/apache/thrift v0.16.0 // indirect
github.com/cloudquery/plugin-sdk/v2 v2.7.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/getsentry/sentry-go v0.20.0 // indirect
github.com/ghodss/yaml v1.0.0 // indirect
Expand All @@ -34,6 +35,7 @@ require (
github.com/mattn/go-isatty v0.0.18 // indirect
github.com/minio/asm2plan9s v0.0.0-20200509001527-cdd76441f9d8 // indirect
github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3 // indirect
github.com/pierrec/lz4/v4 v4.1.15 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/spf13/cast v1.5.0 // indirect
github.com/spf13/cobra v1.6.1 // indirect
Expand Down
9 changes: 7 additions & 2 deletions plugins/source/facebookmarketing/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,16 @@ github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWR
github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI=
github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU=
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
github.com/cloudquery/arrow/go/v13 v13.0.0-20230509053643-898a79b1d3c8 h1:CmgLSEGQNLHpUQ5cU4L4aF7cuJZRnc1toIIWqC1gmPg=
github.com/cloudquery/arrow/go/v13 v13.0.0-20230509053643-898a79b1d3c8/go.mod h1:/XatdE3kDIBqZKhZ7OBUHwP2jaASDFZHqF4puOWM8po=
github.com/cloudquery/arrow/go/v13 v13.0.0-20230525142029-2d32efeedad8 h1:/mgK+To5HNUzuZDWdVygbfn8oaPG5c7I/8qCxwwpWO8=
github.com/cloudquery/arrow/go/v13 v13.0.0-20230525142029-2d32efeedad8/go.mod h1:/XatdE3kDIBqZKhZ7OBUHwP2jaASDFZHqF4puOWM8po=
github.com/cloudquery/plugin-pb-go v1.0.8 h1:wn3GXhcNItcP+6wUUZuzUFbvdL59liKBO37/izMi+FQ=
github.com/cloudquery/plugin-pb-go v1.0.8/go.mod h1:vAGA27psem7ZZNAY4a3S9TKuA/JDQWstjKcHPJX91Mc=
github.com/cloudquery/plugin-sdk/v2 v2.7.0 h1:hRXsdEiaOxJtsn/wZMFQC9/jPfU1MeMK3KF+gPGqm7U=
github.com/cloudquery/plugin-sdk/v2 v2.7.0/go.mod h1:pAX6ojIW99b/Vg4CkhnsGkRIzNaVEceYMR+Bdit73ug=
github.com/cloudquery/plugin-sdk/v3 v3.6.5 h1:8BSlY+U73FGyLzL/x8gylmQm3LD+WETSH0OZ6kVVgPA=
github.com/cloudquery/plugin-sdk/v3 v3.6.5/go.mod h1:3JrZXEULmGXpkOukVaRIzaA63d7TJr9Ukp6hemTjbtc=
github.com/cloudquery/plugin-sdk/v3 v3.6.6 h1:qIW/RfpqHSRl7TjXD1+yIYvLQ5+AYGtNe/CWNNT9wMA=
github.com/cloudquery/plugin-sdk/v3 v3.6.6/go.mod h1:3JrZXEULmGXpkOukVaRIzaA63d7TJr9Ukp6hemTjbtc=
github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
Expand Down Expand Up @@ -174,6 +178,7 @@ github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3 h1:+n/aFZefKZp7spd8D
github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3/go.mod h1:RagcQ7I8IeTMnF8JTXieKnO4Z6JCsikNEzj0DwauVzE=
github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=
github.com/pierrec/lz4/v4 v4.1.15 h1:MO0/ucJhngq7299dKLwIMtgTfbkoSPF6AoMYDd8Q4q0=
github.com/pierrec/lz4/v4 v4.1.15/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
github.com/pingcap/errors v0.11.4 h1:lFuQV/oaUMGcD2tqt+01ROSmJs75VG1ToEOkZIZ4nE4=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
Expand Down
2 changes: 1 addition & 1 deletion plugins/source/facebookmarketing/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package main

import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/resources/plugin"
"github.com/cloudquery/plugin-sdk/v2/serve"
"github.com/cloudquery/plugin-sdk/v3/serve"
)

const sentryDsn = "https://a0d398d362d34e63a7ed246f7cb76b5a@o1396617.ingest.sentry.io/4504798123786240"
Expand Down
6 changes: 3 additions & 3 deletions plugins/source/facebookmarketing/resources/plugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/resources/services"
"github.com/cloudquery/plugin-sdk/v2/caser"
"github.com/cloudquery/plugin-sdk/v2/plugins/source"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/caser"
"github.com/cloudquery/plugin-sdk/v3/plugins/source"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

var (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func AdPlacePageSets() *schema.Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdPlacePageSets(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package services

import (
"github.com/apache/arrow/go/v13/arrow"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func AdStudies() *schema.Table {
Expand All @@ -15,12 +16,10 @@ func AdStudies() *schema.Table {
Description: "https://developers.facebook.com/docs/marketing-api/reference/ad-study/#Reading",
Columns: []schema.Column{
{
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: schema.TypeString,
CreationOptions: schema.ColumnCreationOptions{
PrimaryKey: true,
},
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: arrow.BinaryTypes.String,
PrimaryKey: true,
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdStudies(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adaccounts() *schema.Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdaccounts(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package services

import (
"github.com/apache/arrow/go/v13/arrow"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adcloudplayables() *schema.Table {
Expand All @@ -14,12 +15,10 @@ func Adcloudplayables() *schema.Table {
Transform: client.TransformWithStruct(&rest.Adcloudplayable{}, transformers.WithPrimaryKeys("Id")),
Columns: []schema.Column{
{
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: schema.TypeString,
CreationOptions: schema.ColumnCreationOptions{
PrimaryKey: true,
},
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: arrow.BinaryTypes.String,
PrimaryKey: true,
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdcloudplayables(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adcreatives() *schema.Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdcreatives(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adimages() *schema.Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdimages(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
15 changes: 7 additions & 8 deletions plugins/source/facebookmarketing/resources/services/adlabels.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package services

import (
"github.com/apache/arrow/go/v13/arrow"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adlabels() *schema.Table {
Expand All @@ -15,12 +16,10 @@ func Adlabels() *schema.Table {
Description: "https://developers.facebook.com/docs/marketing-api/reference/ad-label#Reading",
Columns: []schema.Column{
{
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: schema.TypeString,
CreationOptions: schema.ColumnCreationOptions{
PrimaryKey: true,
},
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: arrow.BinaryTypes.String,
PrimaryKey: true,
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdlabels(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package services

import (
"github.com/apache/arrow/go/v13/arrow"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adplayables() *schema.Table {
Expand All @@ -14,12 +15,10 @@ func Adplayables() *schema.Table {
Transform: client.TransformWithStruct(&rest.Adplayable{}, transformers.WithPrimaryKeys("Id")),
Columns: []schema.Column{
{
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: schema.TypeString,
CreationOptions: schema.ColumnCreationOptions{
PrimaryKey: true,
},
Name: "account_id",
Resolver: client.ResolveAccountId,
Type: arrow.BinaryTypes.String,
PrimaryKey: true,
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdplayables(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Adrules() *schema.Table {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v3/schema"
)

func fetchAdrules(ctx context.Context, meta schema.ClientMeta, parent *schema.Resource, res chan<- any) error {
Expand Down
4 changes: 2 additions & 2 deletions plugins/source/facebookmarketing/resources/services/ads.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package services
import (
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/client"
"github.com/cloudquery/cloudquery/plugins/source/facebookmarketing/rest"
"github.com/cloudquery/plugin-sdk/v2/schema"
"github.com/cloudquery/plugin-sdk/v2/transformers"
"github.com/cloudquery/plugin-sdk/v3/schema"
"github.com/cloudquery/plugin-sdk/v3/transformers"
)

func Ads() *schema.Table {
Expand Down

0 comments on commit 10954ce

Please sign in to comment.