chore: Add default (#17912)

Follow-up for #17910
cloudquery · May 8, 2024 · 84ea568 · 84ea568
1 parent e7f5a87
commit 84ea568
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/plugins/destination/kafka/client/spec/schema.json b/plugins/destination/kafka/client/spec/schema.json
diff --git a/plugins/destination/kafka/client/spec/spec.go b/plugins/destination/kafka/client/spec/spec.go
@@ -8,9 +8,9 @@ import (
 
 type topicDetails struct {
 	// Number of partitions to create for the topic.
-	NumPartitions int `json:"num_partitions,omitempty" jsonschema:"minimum=1"`
+	NumPartitions int `json:"num_partitions,omitempty" jsonschema:"minimum=1,default=1"`
 	// Replication factor for the topic.
-	ReplicationFactor int `json:"replication_factor,omitempty" jsonschema:"minimum=1"`
+	ReplicationFactor int `json:"replication_factor,omitempty" jsonschema:"minimum=1,default=1"`
 }
 
 type Spec struct {

diff --git a/plugins/destination/kafka/docs/_configuration.md b/plugins/destination/kafka/docs/_configuration.md
@@ -27,6 +27,9 @@ spec:
     # client_id: cq-destination-kafka
     # verbose: false
     # batch_size: 1000
+    # topic_details:
+      # num_partitions: 1
+      # replication_factor: 1
 ```
 
 Note that the Kafka plugin only supports `append` `write_mode`. The (top level) spec section is described in the [Destination Spec Reference](/docs/reference/destination-spec).
diff --git a/plugins/destination/kafka/docs/overview.md b/plugins/destination/kafka/docs/overview.md
@@ -75,7 +75,7 @@ This is the (nested) plugin spec
 
   Number of partitions for the newly created topic.
 
-- `replication_factor` (`integer`) (optional) (1: `1000`)
+- `replication_factor` (`integer`) (optional) (default: `1`)
 
   Replication factor for the topic.