Skip to content

Commit

Permalink
fix(aws)!: Change names of columns which had _ar_ns instead of `_ar…
Browse files Browse the repository at this point in the history
…ns` (#10802)



#### Summary
  • Loading branch information
bbernays committed May 25, 2023
1 parent 4898a64 commit e00ac44
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ func restApiAuthorizers() *schema.Table {
Description: `https://docs.aws.amazon.com/apigateway/latest/api/API_Authorizer.html`,
Resolver: fetchApigatewayRestApiAuthorizers,
Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "apigateway"),
Transform: transformers.TransformWithStruct(&types.Authorizer{}),
Transform: transformers.TransformWithStruct(
&types.Authorizer{},
transformers.WithNameTransformer(client.CreateReplaceTransformer(map[string]string{"ar_ns": "arns"})),
),
Columns: []schema.Column{
client.DefaultAccountIDColumn(true),
client.DefaultRegionColumn(false),
Expand Down
5 changes: 4 additions & 1 deletion plugins/source/aws/resources/services/autoscaling/groups.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ func Groups() *schema.Table {
Description: `https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_AutoScalingGroup.html`,
Resolver: fetchAutoscalingGroups,
Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "autoscaling"),
Transform: transformers.TransformWithStruct(&models.AutoScalingGroupWrapper{}, transformers.WithUnwrapAllEmbeddedStructs()),
Transform: transformers.TransformWithStruct(&models.AutoScalingGroupWrapper{},
transformers.WithUnwrapAllEmbeddedStructs(),
transformers.WithNameTransformer(client.CreateReplaceTransformer(map[string]string{"ar_ns": "arns"})),
),
Columns: []schema.Column{
client.DefaultAccountIDColumn(false),
client.DefaultRegionColumn(false),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ func Stacks() *schema.Table {
Description: `https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_Stack.html`,
Resolver: fetchCloudformationStacks,
Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "cloudformation"),
Transform: transformers.TransformWithStruct(&types.Stack{}),
Transform: transformers.TransformWithStruct(
&types.Stack{},
transformers.WithNameTransformer(client.CreateReplaceTransformer(map[string]string{"ar_ns": "arns"})),
),
Columns: []schema.Column{
client.DefaultAccountIDColumn(false),
client.DefaultRegionColumn(false),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ func IdentityPools() *schema.Table {
Resolver: fetchCognitoIdentityPools,
PreResourceResolver: getIdentityPool,
Multiplex: client.ServiceAccountRegionMultiplexer(tableName, "cognito-identity"),
Transform: transformers.TransformWithStruct(&cognitoidentity.DescribeIdentityPoolOutput{}),
Transform: transformers.TransformWithStruct(
&cognitoidentity.DescribeIdentityPoolOutput{},
transformers.WithNameTransformer(client.CreateReplaceTransformer(map[string]string{"ar_ns": "arns"})),
),
Columns: []schema.Column{
client.DefaultAccountIDColumn(true),
client.DefaultRegionColumn(true),
Expand All @@ -35,7 +38,7 @@ func IdentityPools() *schema.Table {
PrimaryKey: true,
},
{
Name: "saml_provider_ar_ns",
Name: "saml_provider_arns",
Type: arrow.ListOf(arrow.BinaryTypes.String),
Resolver: schema.PathResolver("SamlProviderARNs"),
},
Expand Down
2 changes: 1 addition & 1 deletion website/tables/aws/aws_apigateway_rest_api_authorizers.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ This table depends on [aws_apigateway_rest_apis](aws_apigateway_rest_apis).
|identity_source|utf8|
|identity_validation_expression|utf8|
|name|utf8|
|provider_ar_ns|list<item: utf8, nullable>|
|provider_arns|list<item: utf8, nullable>|
|type|utf8|
2 changes: 1 addition & 1 deletion website/tables/aws/aws_autoscaling_groups.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The following tables depend on aws_autoscaling_groups:
|service_linked_role_arn|utf8|
|status|utf8|
|suspended_processes|json|
|target_group_ar_ns|list<item: utf8, nullable>|
|target_group_arns|list<item: utf8, nullable>|
|termination_policies|list<item: utf8, nullable>|
|traffic_sources|json|
|vpc_zone_identifier|utf8|
Expand Down
2 changes: 1 addition & 1 deletion website/tables/aws/aws_cloudformation_stacks.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ The following tables depend on aws_cloudformation_stacks:
|drift_information|json|
|enable_termination_protection|bool|
|last_updated_time|timestamp[us, tz=UTC]|
|notification_ar_ns|list<item: utf8, nullable>|
|notification_arns|list<item: utf8, nullable>|
|outputs|json|
|parameters|json|
|parent_id|utf8|
Expand Down
4 changes: 2 additions & 2 deletions website/tables/aws/aws_cognito_identity_pools.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ The composite primary key for this table is (**account_id**, **region**, **id**)
|region (PK)|utf8|
|arn|utf8|
|id (PK)|utf8|
|saml_provider_ar_ns|list<item: utf8, nullable>|
|saml_provider_arns|list<item: utf8, nullable>|
|allow_unauthenticated_identities|bool|
|identity_pool_id|utf8|
|identity_pool_name|utf8|
|allow_classic_flow|bool|
|cognito_identity_providers|json|
|developer_provider_name|utf8|
|identity_pool_tags|json|
|open_id_connect_provider_ar_ns|list<item: utf8, nullable>|
|open_id_connect_provider_arns|list<item: utf8, nullable>|
|supported_login_providers|json|
|result_metadata|json|

0 comments on commit e00ac44

Please sign in to comment.