Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Driver - 64 Character Identifier Limit #1

Closed
sethcenterbar opened this issue Nov 25, 2020 · 2 comments
Closed

MySQL Driver - 64 Character Identifier Limit #1

sethcenterbar opened this issue Nov 25, 2020 · 2 comments

Comments

@sethcenterbar
Copy link
Contributor

sethcenterbar commented Nov 25, 2020

I love the idea behind this project and think it will be incredibly useful for many organizations. I'm hoping to be a contributor here, so let me know how I can help!

When running the example.config.yml, ec2 instances attempts to create a column named 'capacity_reservation_target_capacity_reservation_resource_group_arn'.

Error: Error 1059: Identifier name 'capacity_reservation_target_capacity_reservation_resource_group_arn' is too long

MySQL has a 64 character limit for identifiers, so we should find a way to identify and compact names > 64 characters long when using the MySQL driver. For the sake of autocomplete and api similarity, I actually think simply taking the first 64 characters will be the best bet in most situations.

@ghost
Copy link

ghost commented Nov 25, 2020

@sethcenterbar Thanks! I've removed the prefix capacity_reservation_target from this column so hopefully this should solve it. can you test it please?

In other situation we can take your approach though I think we should avoid really long columns.

@ghost ghost added the bug label Nov 30, 2020
@ghost ghost closed this as completed Nov 30, 2020
@dancompton

This comment was marked as spam.

erezrokah pushed a commit that referenced this issue Aug 14, 2022
yevgenypats added a commit that referenced this issue Nov 1, 2022
yevgenypats added a commit that referenced this issue Nov 17, 2022
kodiakhq bot pushed a commit that referenced this issue Nov 18, 2022
Streamlining our product updates. I'll be adding stuff here and releasing on monthly basis here and on our newsletter
kodiakhq bot pushed a commit that referenced this issue Nov 18, 2022
Remove empty section
@yevgenypats yevgenypats reopened this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants