fix(aws-s3): Always use models.WrappedBucket to avoid panic #10827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
changed the title
disq
approved these changes
May 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [17.3.1](plugins-source-aws-v17.3.0...plugins-source-aws-v17.3.1) (2023-05-18) ### This Release has the Following Changes to Tables - Table `aws_cloudformation_stack_templates`: column added with name `template_body_text` and type `String` ### Bug Fixes * **aws-s3:** Always use models.WrappedBucket to avoid panic ([#10827](#10827)) ([be55852](be55852)) * **aws:** Handle YAML cloudformation template bodies ([#10826](#10826)) ([498f394](498f394)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the column resolvers return an error, it can happen that
resolveS3BucketsAttributesgets called with an item that is of typetypes.Bucketinstead ofmodels.WrappedBucket. To avoid uncertainty (and the panic), we can always usemodels.WrappedBucket.