Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Log failed message on column resolver exception in Plugin SDK #18002

Closed
hermanschaaf opened this issue May 17, 2024 · 0 comments · Fixed by cloudquery/plugin-sdk-python#172
Closed

feat: Log failed message on column resolver exception in Plugin SDK #18002

hermanschaaf opened this issue May 17, 2024 · 0 comments · Fixed by cloudquery/plugin-sdk-python#172
Assignees
@hermanschaaf
Labels
area/plugin-sdk/python

Comments

@hermanschaaf
Copy link
Member

When getting an incompatible type error like this:

Traceback (most recent call last):
  File "/Users/hermanschaaf/.virtualenvs/typeform/lib/python3.11/site-packages/cloudquery/sdk/scalar/int.py", line 42, in set
    val = int(value)
          ^^^^^^^^^^
ValueError: invalid literal for int() with base 10: 'History feedback'

it would be very useful if the full record (or at least the offending column and value) were logged, so that it can be fixed more easily.
@hermanschaaf hermanschaaf mentioned this issue May 17, 2024
Merged
@hermanschaaf hermanschaaf self-assigned this May 17, 2024
kodiakhq bot pushed a commit to cloudquery/plugin-sdk-python that referenced this issue May 17, 2024
@hermanschaaf
feat: Log resource when exception occurs to aid debugging (#172)
6403290 
This change will allow plugin authors to see the resource that caused the exception, helping them find the underlying cause. To get this level of information, `--log-level debug` needs to be passed to the plugin server (or the CLI, depending on whether or not the plugin is run using the grpc registry)

Closes cloudquery/cloudquery#18002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermanschaaf hermanschaaf

Labels
area/plugin-sdk/python
Projects
Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Log resource when exception occurs to aid debugging cloudquery/plugin-sdk-python
1 participant
@hermanschaaf