Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL identifier too long #35

Closed
zscholl opened this issue Jan 16, 2021 · 3 comments
Closed

MySQL identifier too long #35

zscholl opened this issue Jan 16, 2021 · 3 comments

Comments

@zscholl
Copy link
Contributor

zscholl commented Jan 16, 2021

👋 When running cloudquery against AWS resources using MySQL I get the below error

Error 1059: Identifier name 'fk_aws_redshift_cluster_parameter_group_statuses_cluster_parameter_status_list' is too long

MySQL has a 64 character limit on column names and it looks like that is not adjustable: https://dev.mysql.com/doc/refman/5.7/en/identifier-length.html

Maybe column names should be truncated depending on providers? Or as a configuration option?
ghost pushed a commit that referenced this issue Jan 16, 2021
Bugfix: MySQL identifier too long for foreign key in redshift
6a9b36d 
#35
@yevgenypats
Copy link
Member

@zscholl Hi! I pushed a fix to v0.8.5. I think this is second time this bug surface so it's good time to add basic system tests. I'll add those tomorrow and it should catch those kinds of issues before release/merge.

@zscholl
Copy link
Contributor Author

zscholl commented Jan 16, 2021

Wow thanks! 😄

Yeah some basic validation tests that create the tables for each supported database would be a great addition 👍

@zscholl
Copy link
Contributor Author

zscholl commented Jan 16, 2021

Tested the fix and it works, thank you!

@zscholl zscholl closed this as completed Jan 16, 2021
erezrokah pushed a commit that referenced this issue Aug 14, 2022
@cq-bot
fix(deps): Update module github.com/cloudquery/cq-provider-sdk to v0.…
e570a53 
…13.4 (#35)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.13.3` -> `v0.13.4` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.13.4`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.13.4)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.13.3...v0.13.4)

##### Features

-   **tests:** Fetch only the resources required for test being run ([#&#8203;400](https://togithub.com/cloudquery/cq-provider-sdk/issues/400)) ([5fa0315](https://togithub.com/cloudquery/cq-provider-sdk/commit/5fa031587a54cc967a496448c0e0fc06546c32a9))

##### Bug Fixes

-   **deps:** Update module github.com/cloudquery/faker/v3 to v3.7.6 ([#&#8203;412](https://togithub.com/cloudquery/cq-provider-sdk/issues/412)) ([c02f433](https://togithub.com/cloudquery/cq-provider-sdk/commit/c02f433f17793397803a248cec15fdcb13926f32))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zscholl @yevgenypats