New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws): Add AWS RAM resources #3961
Conversation
844c598
to
3891783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with single nit
32b29d1
to
4c840c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Just some minor nits / questions.
4c840c8
to
0898514
Compare
01b596b
to
e34c1d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the new PKColumns option 😍
plugins/source/aws/docs/tables/aws_ram_resource_share_invitations.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just noticed two ARNs column names that should ideally be consistent with other AWS tables.
9f90ace
to
d946abe
Compare
d946abe
to
6d26d32
Compare
🤖 I have created a release *beep* *boop* --- ## [4.12.0](plugins-source-aws-v4.11.3...plugins-source-aws-v4.12.0) (2022-11-10) ### Features * **aws:** Add AWS RAM resources ([#3961](#3961)) ([0c16add](0c16add)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Add AWS RAM resources (cloudquery#1984)
🤖 I have created a release *beep* *boop* --- ## [4.12.0](cloudquery/cloudquery@plugins-source-aws-v4.11.3...plugins-source-aws-v4.12.0) (2022-11-10) ### Features * **aws:** Add AWS RAM resources ([cloudquery#3961](cloudquery#3961)) ([0c16add](cloudquery@0c16add)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Add AWS RAM resources (#1984)