Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Add AWS RAM resources #3961

Merged
merged 8 commits into from Nov 10, 2022
Merged

feat(aws): Add AWS RAM resources #3961

merged 8 commits into from Nov 10, 2022

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Nov 8, 2022

Add AWS RAM resources (#1984)

@candiduslynx candiduslynx linked an issue Nov 8, 2022 that may be closed by this pull request
@candiduslynx candiduslynx self-assigned this Nov 8, 2022
@cq-bot cq-bot added the aws label Nov 8, 2022
@candiduslynx candiduslynx changed the title fea(aws): Add AWS RAM resources (#1984) feat(aws): Add AWS RAM resources (#1984) Nov 8, 2022
@candiduslynx candiduslynx changed the title feat(aws): Add AWS RAM resources (#1984) feat(aws): Add AWS RAM resources Nov 8, 2022
@candiduslynx candiduslynx force-pushed the feat/aws/ram branch 3 times, most recently from 844c598 to 3891783 Compare November 8, 2022 17:17
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with single nit

plugins/source/aws/codegen/recipes/ram.go Show resolved Hide resolved
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just some minor nits / questions.

plugins/source/aws/docs/tables/aws_ram_principals.md Outdated Show resolved Hide resolved
plugins/source/aws/codegen/recipes/base.go Outdated Show resolved Hide resolved
@candiduslynx candiduslynx force-pushed the feat/aws/ram branch 2 times, most recently from 01b596b to e34c1d9 Compare November 9, 2022 16:23
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new PKColumns option 😍

Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed two ARNs column names that should ideally be consistent with other AWS tables.

@candiduslynx candiduslynx requested review from disq and removed request for yevgenypats, jsonpr and disq November 10, 2022 08:41
@candiduslynx candiduslynx added resource automerge Automatically merge once required checks pass labels Nov 10, 2022
@kodiakhq kodiakhq bot merged commit 0c16add into main Nov 10, 2022
@kodiakhq kodiakhq bot deleted the feat/aws/ram branch November 10, 2022 08:49
kodiakhq bot pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop*
---


## [4.12.0](plugins-source-aws-v4.11.3...plugins-source-aws-v4.12.0) (2022-11-10)


### Features

* **aws:** Add AWS RAM resources ([#3961](#3961)) ([0c16add](0c16add))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
SCKelemen pushed a commit to SCKelemen/cloudquery that referenced this pull request Nov 15, 2022
SCKelemen pushed a commit to SCKelemen/cloudquery that referenced this pull request Nov 15, 2022
🤖 I have created a release *beep* *boop*
---


## [4.12.0](cloudquery/cloudquery@plugins-source-aws-v4.11.3...plugins-source-aws-v4.12.0) (2022-11-10)


### Features

* **aws:** Add AWS RAM resources ([cloudquery#3961](cloudquery#3961)) ([0c16add](cloudquery@0c16add))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge once required checks pass
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

AWS Resource Access Manager Support
5 participants