Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): More SSM resources #4381

Merged
merged 5 commits into from Nov 16, 2022
Merged

feat(aws): More SSM resources #4381

merged 5 commits into from Nov 16, 2022

Conversation

disq
Copy link
Member

@disq disq commented Nov 11, 2022 •
edited

Hopefully implements #1409

I'm not sure if this is enough or if we need more (DescribeInstancePatchStates for instance... which can take multiple InstanceIds as input, so challenges ahead)

@cq-bot cq-bot added the aws label Nov 11, 2022
@disq disq linked an issue Nov 11, 2022 that may be closed by this pull request
Add Support for AWS::SSM::* #1409
Closed
3 tasks
hermanschaaf
hermanschaaf approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I think we can always start here and then use the the Describe...-type calls later if it turns out they are required by some users.

bbernays
bbernays approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I think DescribeInstancePatchStates is just a relation for instance_patches so shouldn't be that bad

@disq
Copy link
Member Author

disq commented Nov 15, 2022

Maybe merge for now and see it in the field vs. customer requirements/issues?

@erezrokah erezrokah added automerge Automatically merge once required checks pass priority merge labels Nov 16, 2022
@kodiakhq kodiakhq bot merged commit 42b0c70 into cloudquery:main Nov 16, 2022
@cq-bot cq-bot mentioned this pull request Nov 16, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 16, 2022
@cq-bot
chore(main): Release plugins-source-aws v6.2.0 (#4698)
992b4ee 
🤖 I have created a release *beep* *boop*
---


## [6.2.0](plugins-source-aws-v6.1.0...plugins-source-aws-v6.2.0) (2022-11-16)


### Features

* **aws:** Add Support for Eventbridge scheduler ([#4693](#4693)) ([a4ef661](a4ef661))
* **aws:** More SSM resources ([#4381](#4381)) ([42b0c70](42b0c70))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@disq disq deleted the feat/aws_more_ssm branch November 16, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@erezrokah erezrokah erezrokah approved these changes

@bbernays bbernays bbernays approved these changes

@jsonpr jsonpr Awaiting requested review from jsonpr

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for AWS::SSM::*
5 participants
@disq @hermanschaaf @erezrokah @bbernays @cq-bot