Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update golangci-lint to v1.55.2 #15212

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Nov 10, 2023

This update has to be performed manually, as the following check need to be disabled:

  1. unchecked-type-assertion

    cl := meta.(*client.Client)
  2. import-alias-naming
    This check requires a specific alias naming for imports.

  3. redundant-import-alias
    This check will fail if the alias is the last part of the import path, although the package name may differ.
    See bug: redundant-import-alias rule check for import path instead of package name mgechev/revive#936 for more deetails.

This will fail in `golangci-lint` `v1.55.x`
@candiduslynx candiduslynx requested a review from a team as a code owner November 10, 2023 08:43
@candiduslynx candiduslynx requested review from hermanschaaf and removed request for a team November 10, 2023 08:43
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Nov 10, 2023
@cq-bot cq-bot added the area/ci label Nov 10, 2023
@candiduslynx candiduslynx changed the title chore(ci): Disable unchecked-type-assertion check in revive chore(ci): Update golangci-lint to v1.55.2 Nov 10, 2023
This reverts commit 48decf8.
@kodiakhq kodiakhq bot merged commit acd4f30 into main Nov 10, 2023
99 checks passed
@kodiakhq kodiakhq bot deleted the candiduslynx-patch-1 branch November 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/plugin/source/aws automerge Automatically merge once required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants