chore: Replacing deprecated run.skip-dirs for issues.exclude-dirs in golanci.yml #17916
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorian6255
changed the title
dorian6255
changed the title
dorian6255
force-pushed
the
ci-golangci-lint-skipdir
branch
from
6329788
to
618abb5
Compare
erezrokah
approved these changes
May 9, 2024
|
Thanks @dorian6255, looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolve the issue #17455 => it removes the deprecated run.skipdir from .golangci.yml
I used the documentation for golangci-lint here : https://golangci-lint.run/usage/configuration/#issues-configuration
Changes
there was only 2 .golangci.yml that needed changes (out of 4) :
I did not change theses 2 :
Testing method
I tested with golangci-lint before and after my modification :
Before:
After:
This is my first contribution, I hope I did everything well,
Have a good day