Warn instead of throwing fatal error if specific resource collection fails #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
that referenced
this pull request
Dec 17, 2020
|
@chongyangshi Thanks for opening this! I've added a bit stricter check specifically for |
ghost
closed this
erezrokah
pushed a commit
to erezrokah/cloudquery
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- * Added access groups ([cloudquery#14](https://github.com/cloudquery/cq-provider-cloudflare/issues/14)) ([64c03cc](https://github.com/cloudquery/cq-provider-cloudflare/commit/64c03cc500515b2209b27c223f40e18ae8550f0c)) * Added certificate packs ([cloudquery#12](https://github.com/cloudquery/cq-provider-cloudflare/issues/12)) ([5f22e18](https://github.com/cloudquery/cq-provider-cloudflare/commit/5f22e181ae6dab564992d2aa578617344a2c800c)) * Added workers ([cloudquery#6](https://github.com/cloudquery/cq-provider-cloudflare/issues/6)) ([32152d4](https://github.com/cloudquery/cq-provider-cloudflare/commit/32152d4e21ca07651e963da65933f6e623997479)) * Cleanup ([cloudquery#16](https://github.com/cloudquery/cq-provider-cloudflare/issues/16)) ([391dc34](https://github.com/cloudquery/cq-provider-cloudflare/commit/391dc3430f182d6635af21ce212d9ef45f35cb09)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([cloudquery#9](https://github.com/cloudquery/cq-provider-cloudflare/issues/9)) ([b62ec0d](https://github.com/cloudquery/cq-provider-cloudflare/commit/b62ec0d8742764c5541fb2501bb35f0919505148)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.14.7 ([cloudquery#10](https://github.com/cloudquery/cq-provider-cloudflare/issues/10)) ([7b03621](https://github.com/cloudquery/cq-provider-cloudflare/commit/7b03621fe1f6ff9cb3c1ee2780e1a07caa793993)) * Remove redundant col ([cloudquery#15](https://github.com/cloudquery/cq-provider-cloudflare/issues/15)) ([d2959bb](https://github.com/cloudquery/cq-provider-cloudflare/commit/d2959bbbb07f4b2308d6072a84164d793e1c33fa)) * Updated account pagination ([cloudquery#13](https://github.com/cloudquery/cq-provider-cloudflare/issues/13)) ([ad6e6a8](https://github.com/cloudquery/cq-provider-cloudflare/commit/ad6e6a8206540e3d0823bb98783b5ca5b747c906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
pushed a commit
to erezrokah/cloudquery
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.1.2](https://github.com/cloudquery/cq-provider-cloudflare/compare/v0.1.1...v0.1.2) (2022-08-10) ### Features * Added access groups ([cloudquery#14](https://github.com/cloudquery/cq-provider-cloudflare/issues/14)) ([64c03cc](https://github.com/cloudquery/cq-provider-cloudflare/commit/64c03cc500515b2209b27c223f40e18ae8550f0c)) * Added certificate packs ([cloudquery#12](https://github.com/cloudquery/cq-provider-cloudflare/issues/12)) ([5f22e18](https://github.com/cloudquery/cq-provider-cloudflare/commit/5f22e181ae6dab564992d2aa578617344a2c800c)) * Added workers ([cloudquery#6](https://github.com/cloudquery/cq-provider-cloudflare/issues/6)) ([32152d4](https://github.com/cloudquery/cq-provider-cloudflare/commit/32152d4e21ca07651e963da65933f6e623997479)) ### Bug Fixes * Cleanup ([cloudquery#16](https://github.com/cloudquery/cq-provider-cloudflare/issues/16)) ([391dc34](https://github.com/cloudquery/cq-provider-cloudflare/commit/391dc3430f182d6635af21ce212d9ef45f35cb09)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([cloudquery#9](https://github.com/cloudquery/cq-provider-cloudflare/issues/9)) ([b62ec0d](https://github.com/cloudquery/cq-provider-cloudflare/commit/b62ec0d8742764c5541fb2501bb35f0919505148)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.14.7 ([cloudquery#10](https://github.com/cloudquery/cq-provider-cloudflare/issues/10)) ([7b03621](https://github.com/cloudquery/cq-provider-cloudflare/commit/7b03621fe1f6ff9cb3c1ee2780e1a07caa793993)) * Docs ([cloudquery#18](https://github.com/cloudquery/cq-provider-cloudflare/issues/18)) ([9c0c285](https://github.com/cloudquery/cq-provider-cloudflare/commit/9c0c285d3a9d2ca744cc96c60dc8eef70eb642f8)) * Remove redundant col ([cloudquery#15](https://github.com/cloudquery/cq-provider-cloudflare/issues/15)) ([d2959bb](https://github.com/cloudquery/cq-provider-cloudflare/commit/d2959bbbb07f4b2308d6072a84164d793e1c33fa)) * Updated account pagination ([cloudquery#13](https://github.com/cloudquery/cq-provider-cloudflare/issues/13)) ([ad6e6a8](https://github.com/cloudquery/cq-provider-cloudflare/commit/ad6e6a8206540e3d0823bb98783b5ca5b747c906)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Synced local file(s) with [cloudquery/.github](https://github.com/cloudquery/.github). --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#2563370092](https://github.com/cloudquery/.github/actions/runs/2563370092)
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
* feat: Ignore Common Errors * fix imports
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
pilvikala
added a commit
that referenced
this pull request
Oct 31, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying a complex AWS or GCP environment with a service user / service role, it is common that the service user or service role does not have permissions to view all of the cloud environment. In AWS it is also possible for resource policies to deny access to certain resources for the service user or service role before IAM policies even apply.
Even if resource collection for a subset of resources fail (e.g. some S3 buckets and some KMS keys cannot be collected due to explicit Deny in their resource policies), other resources collected from the same account (e.g. EC2 instances) should still be useful for querying, and it shouldn't be the case that we abandon the entire fetch run. Therefore in this PR I suggest that we log a warning instead of a fatal error if specific resources fail to be collected.