fix: bulk insert ec2 for each describe call instead of one by one (#19)

cloudquery · Mar 18, 2021 · 7080327 · 7080327
1 parent 3636a8b
commit 7080327
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/resources/ec2/instances.go b/resources/ec2/instances.go
@@ -587,10 +587,12 @@ func (c *Client) instances(gConfig interface{}) error {
 		if err != nil {
 			return err
 		}
+		var instances []*Instance
 		for _, reservation := range output.Reservations {
-			c.log.Info("Fetched resources", "resource", "ec2.instances", "count", len(reservation.Instances))
-			c.db.ChunkedCreate(c.transformInstances(&reservation.Instances))
+			instances = append(instances, c.transformInstances(&reservation.Instances)...)
 		}
+		c.log.Info("Fetched resources", "resource", "ec2.instances", "count", len(instances))
+		c.db.ChunkedCreate(instances)
 		if aws.ToString(output.NextToken) == "" {
 			break
 		}