Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: FSx file-systems, aliases, DRAs #1273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rocketbitz
Copy link

@rocketbitz rocketbitz commented Jul 22, 2022

Summary

cloudquery/cloudquery#1375
cloudquery/cloudquery#1376
cloudquery/cloudquery#1378


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@rocketbitz rocketbitz requested a review from a team as a code owner July 22, 2022 19:24
@rocketbitz rocketbitz requested review from zagronitay and removed request for a team July 22, 2022 19:24
@rocketbitz rocketbitz changed the title [WIP] FSx file-systems, aliases, DRAs FSx file-systems, aliases, DRAs Jul 22, 2022
@rocketbitz rocketbitz changed the title FSx file-systems, aliases, DRAs feat: FSx file-systems, aliases, DRAs Jul 23, 2022
@yevgenypats yevgenypats requested review from roneli and irmatov and removed request for zagronitay July 25, 2022 06:53
@zagronitay
Copy link
Contributor

Hi @rocketbitz .

Thank you for submitting this PR.
Looks great overall.

Few comments:

  1. Docs are missing.
  2. Mock tests are missing.
  3. FSX resource is not mapped in the provider.go
  4. Integration tests missing local + prod folders.
  5. resolveFsxFileSystemTags seems to be not implemented.

You may find explanation to the missing steps on https://github.com/cloudquery/cq-provider-aws/blob/main/docs/contributing/adding_a_new_resource.md#setting-up-the-resource

Feel free to comment on here or on our discord chat https://discord.gg/bAdBG5WU

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants