Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

update plugin with yaml tags #2

Merged
merged 1 commit into from
Feb 16, 2021
Merged

update plugin with yaml tags #2

merged 1 commit into from
Feb 16, 2021

Conversation

kkeller-cb
Copy link
Contributor

We noticed that the Account array was always empty. This pr adds yaml tags to the config structs so it populates.

@yevgenypats
Copy link
Member

@kkeller-cb Thanks! I double tested it now and looks like some of the fields do get populated as long as you specify it in the config.yml. I did see that the RoleARN does not get populated without the tag indeed.

I think the yaml package uses a snake_case by default for the tags. Anyway to avoid bugs like with RoleARN I think it is a good practice to have the tags explicit and merge this (there is one typo in the PR though).

provider.go Outdated Show resolved Hide resolved
@yevgenypats yevgenypats merged commit 8c26dc6 into cloudquery:main Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants