Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Allow fetching EBS volumes #54

Merged
merged 4 commits into from
May 3, 2021
Merged

Conversation

bombergio
Copy link
Contributor

With this PR adding new config argument ec2.ebs_volumes to fetch EC2 EBS volumes.

Copy link
Contributor

@James-Quigley James-Quigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

resources/ec2_ebs_volumes.go Show resolved Hide resolved
resources/ec2_ebs_volumes.go Show resolved Hide resolved
@bombergio
Copy link
Contributor Author

bombergio commented May 3, 2021

You are referencing outdated EC2 SDK - v 0.24.0, while I was using v 1.2.0 (and the same version is used in the module )
As you can see in the EC2 v1.2.0, all integer fields are of type int32 and there is a field name throughput.
Thanks for pointing to missing Attachments and mocks, I'll add them in the next commit.

@yevgenypats
Copy link
Member

@bombergio Thanks! Merging.

@yevgenypats yevgenypats merged commit 99fc584 into cloudquery:main May 3, 2021
@bombergio bombergio deleted the add-ec2-ebs branch May 3, 2021 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants