Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flatten tables in GetTables gRPC call #57

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: Flatten tables in GetTables gRPC call #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/grpc/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { pluginV3 } from '@cloudquery/plugin-pb-javascript';
import grpc = require('@grpc/grpc-js');

import { Plugin } from '../plugin/plugin.js';
import { encodeTables } from '../schema/table.js';
import { encodeTables, flattenTables } from '../schema/table.js';

export class MigrateTable extends pluginV3.cloudquery.plugin.v3.Sync.MessageMigrateTable {}
export class DeleteStale extends pluginV3.cloudquery.plugin.v3.Write.MessageDeleteStale {}
Expand Down Expand Up @@ -81,8 +81,12 @@ export class PluginServer extends pluginV3.cloudquery.plugin.v3.UnimplementedPlu
this.plugin
.tables({ tables, skipTables, skipDependentTables })
.then((tables) => {
const flattened = flattenTables(tables);
// eslint-disable-next-line promise/no-callback-in-promise
return callback(null, new pluginV3.cloudquery.plugin.v3.GetTables.Response({ tables: encodeTables(tables) }));
return callback(
null,
new pluginV3.cloudquery.plugin.v3.GetTables.Response({ tables: encodeTables(flattened) }),
);
})
.catch((error) => {
// eslint-disable-next-line promise/no-callback-in-promise
Expand Down