feat: Better OTEL traces, add metrics #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
erezrokah
force-pushed
the
feat/open_telemetry
branch
from
7a719a5
to
f0615d7
Compare
erezrokah
requested review from
bbernays,
murarustefaan,
candiduslynx and
marianogappa
and removed request for
candiduslynx and
bbernays
erezrokah
commented
Jun 27, 2024
| @@ -140,45 +136,12 @@ func (s *PluginServe) newCmdPluginServe() *cobra.Command { | |||
| logger = log.Output(zerolog.ConsoleWriter{Out: os.Stdout}).Level(zerologLevel) | |||
| } | |||
|
|
|||
| if otelEndpoint != "" { | |||
There was a problem hiding this comment.
Moved in to opentelemetry.go
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- ## [4.49.0](v4.48.0...v4.49.0) (2024-06-27) ### Features * Better OTEL traces, add metrics ([#1751](#1751)) ([874c33a](874c33a)) ### Bug Fixes * **deps:** Update module github.com/hashicorp/go-retryablehttp to v0.7.7 [SECURITY] ([#1774](#1774)) ([e5e8e7e](e5e8e7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jun 27, 2024
#### Summary Goes with cloudquery/plugin-sdk#1751 Opening for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trying to follow https://www.honeycomb.io/blog/opentelemetry-best-practices-naming to have some convention and namespaces for traces.
Also removed
syncDfsas it doesn't really add additional information.I've added
invocationIDto traces, but not metrics as using a random value for a metric attribute will cause high cardinality (that will increase over time)Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)