This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
suggested changes
Nov 6, 2021
jmattheis
suggested changes
Nov 7, 2021
jmattheis
suggested changes
Nov 9, 2021
jmattheis
reviewed
Nov 14, 2021
jmattheis
reviewed
Nov 16, 2021
jmattheis
reviewed
Nov 16, 2021
jmattheis
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little remark, then you can merge & rebase it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story
As a supporter, I want to be able to guide the person who needs my help through the process of starting the agent. This must be possible on a phone call.
Preconditions
A simple PHP/HTML page that serves the downloads of the PC Assist app will be created soon. (not subject of this task)
Task
Create a pairing code
Config extension
Extend the plexus.config with optional settings like
Session creation
If the
PLEXUS_PAIRING_URL
is givenThe plexus server must accept the two extra fields
supporter_name
andsupporter_avatar
on session creation.For example:
On session creation, the Plexus server must send a json POST request to
{PLEXUS_PAIRING_URL}
for example https://pc-assist.app/sessions/ containing the base URL of the new pairing endpoint of the Plexus server (see below).The above URL will return pairing data as follows.
If you request the
pairing_url
you will get a 302 redirect to theredirect_url
.if the pairing code has been retrieved successfully, it must be included into the response of the session creation, for example.
Pairing creation
Now it's time to provide a pairing URL on Plexus.
If the request to the public pairing service on https://pc-assist.app has returned a pairing code and a redirect URL, store the code in the memory of the plexus server and make the redirect URL available. The PC Assist desktop app will connect there.
With the above example, the plexus server must make the URL
GET https://localhost:8080/pairing/7auu83
available. It must return a json object like