Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Inherit font smoothing for secondary links #672

Merged
merged 1 commit into from Jan 25, 2023
Merged

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Jan 25, 2023

Description

The link component resets font smoothing at the component boundary, which makes sense for most cases except secondary links, which inherit font weight.

It's a chore: cause it's a bugfix for a change that hasn't gone out yet.

Related links, issue #, if available: n/a

How has this been tested?

Only locally, but this should be screenshot testing visible.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot requested a review from a team as a code owner January 25, 2023 18:51
@avinashbot avinashbot requested review from Al-Dani and removed request for a team January 25, 2023 18:52
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // No change to project coverage 👍

Coverage data is based on head (a6d4c99) compared to base (090a87d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16781    16781           
  Branches     4631     4631           
=======================================
  Hits        15603    15603           
  Misses       1101     1101           
  Partials       77       77           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. LGTM!

@avinashbot avinashbot merged commit 88f1cca into main Jan 25, 2023
@avinashbot avinashbot deleted the fix-smoothing branch January 25, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants